Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

[Lenovo] Add exclusion - #6684

Merged
jeremyn merged 3 commits into
EFForg:masterfrom
fuglede:lenovo-fix
Aug 31, 2016
Merged

jeremyn merged 3 commits into
EFForg:masterfrom
fuglede:lenovo-fix

Conversation

@fuglede

@fuglede fuglede commented Aug 30, 2016

Copy link
Copy Markdown
Contributor

@jeremyn

jeremyn commented Aug 30, 2016 •

Copy link
Copy Markdown
Contributor

What's the purpose of utils/ruleset-coverage-whitelist.txt? I don't know what that file is for or when it should be changed.

EDIT: which is sort of funny when you realize I recently updated a script that modifies that file in pull request #6246.

EDIT2: fixed bad grammar in first edit

EDIT3: convenience link to utils/ruleset-coverage-whitelist.txt here .

@fuglede

fuglede commented Aug 30, 2016 •

Copy link
Copy Markdown
Contributor Author

@jeremyn: When the ruleset test requirements were introduced last year, the requirements would not be satisfied for a large part of the existing ruleset collection. Thus, a whitelist was introduced to allow the test to run. Each entry consists of the name of the whitelisted ruleset together with its sha256sum, and if a ruleset is included, it will not be included in the test. As we continue to update the database, the length of the whitelist will continue to decrease, but in this case, I'll not have the time to produce the thorough update required to remove it from the whitelist, so I simply updated the hash. As you've noticed, we have a simple script for eliminating unused entries (which will not change anything functionally, but it tells us a bit about where we are). You'll probably see that happen every now and then.

Now, the obvious question is why the test ran anyway ...

@jeremyn

jeremyn commented Aug 30, 2016

Copy link
Copy Markdown
Contributor

Oh, I see. I just had a hassle with test failures in pull request #6683, though not as many as you have here. If I had added BusinessInsider.xml to the whitelist, I could have avoided the extra rewrites. Of course that would not have been good to do especially since BusinessInsider.xml isn't in the whitelist already.

@jeremyn

jeremyn commented Aug 31, 2016

Copy link
Copy Markdown
Contributor

By the way, I looked at this and couldn't figure it out. My vague idea is that something is wrong in Travis.

@fuglede

fuglede commented Aug 31, 2016

Copy link
Copy Markdown
Contributor Author

I found the explanation; see #6689.

@jeremyn jeremyn closed this Aug 31, 2016
@jeremyn jeremyn reopened this Aug 31, 2016
@jeremyn

jeremyn commented Aug 31, 2016

Copy link
Copy Markdown
Contributor

Why did you remove the trailing slash from

<exclusion pattern="^http://www\.lenovo\.com/(?:lenovorecovery|support|training)" />

and the related tests? Also, you can remove the ?: for simplicity.

@fuglede

fuglede commented Aug 31, 2016

Copy link
Copy Markdown
Contributor Author

Fixed the non-capturing groups. I removed the slash to ensure that the pattern would match both http://www.lenovo.com/lenovorecovery and http://www.lenovo.com/lenovorecovery/ (and similarly for the others; note that https://www.lenovo.com/training is currently broken).

@jeremyn
jeremyn merged commit 11b3664 into EFForg:master Aug 31, 2016
@jeremyn

jeremyn commented Aug 31, 2016

Copy link
Copy Markdown
Contributor

Thanks for updating the non-capturing groups.

I see what you mean about the trailing slash. In #5601 we're discussing some ambiguity about trailing slashes. It'd be great if you could contribute to that discussion.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants